Re: [PATCH v2 4/4] spi: geni-qcom: Add target abort support

[Konrad Dybcio]

On 2/4/26 5:57 PM, Mark Brown wrote:
> On Wed, Feb 04, 2026 at 05:41:46PM +0100, Konrad Dybcio wrote:
>> On 2/4/26 5:28 PM, Praveen Talari wrote:
> 
>>> +	if (spi->target)
>>> +		spi->target_abort = spi_geni_target_abort;
> 
>> The same check is made in core:
> 
>> spi_target_abort()
>> -> spi_controller_is_target()
> 
>> So I'm assuming the intention was to allow assigning the func pointer
>> indiscriminately. Other drivers seem to do it both ways.
> 
>> Mark, any specific preference?
> 
> Not really TBH, it's redundant in the driver but if the people working
> on the driver find having the check there saves them having to check
> that the core does the right thing that's fine.  It's not like this is a
> fast path.

Thanks

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad