Re: [PATCH] kbuild: install-extmod-build: do not exclude scripts/dtc/libfdt/
From: Nathan Chancellor
Date: Wed Feb 04 2026 - 13:14:09 EST
On Wed, Feb 04, 2026 at 07:31:57AM -0600, Rob Herring wrote:
> On Wed, Feb 4, 2026 at 2:45 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
> > Ah, thanks for that information. Moving the libfdt.h bits out of
> > bootinfo.h does not seem like it would be too difficult but I am less
> > sure about asm/machine.h. Alternatively, maybe this could be avoided by
> > separating out what you would need from bootinfo.h into its own header
> > but I did not look too hard.
>
> There shouldn't be that many locations using libfdt functions. Add the
> header where it is used. IWYU
>
> > As for a solution within install-extmod-build, maybe the libfdt headers
> > could be included so that inadvertent inclusions of libfdt.h do not
> > break the build but the link fails if the module actually tries to use
> > any libfdt functions?
>
> You do this and then we get to keep the work-around forever as no one
> will care. MIPS is a mess that needs to be cleaned up.
Yeah, that is a valid perspective, I won't push that further. Thanks for
chiming in.
Cheers,
Nathan