Re: [PATCH net-next V2] net/mlx5e: SHAMPO, Switch to header memcpy

[Jacob Keller]

On 2/4/2026 12:03 PM, Tariq Toukan wrote:
> Performance numbers for x86:
> +---------------------------------------------------------+
> | Test                | Baseline   | Header Copy | Change |
> |---------------------+------------+-------------+--------|
> | iperf3 oncpu        |  59.5 Gbps |  64.00 Gbps |   7 %  |
> | iperf3 offcpu       | 102.5 Gbps | 104.20 Gbps |   2 %  |
> | kperf oncpu         | 115.0 Gbps | 130.00 Gbps |  12 %  |
> | XDP_DROP (skb mode) |   3.9 Mpps |   3.9 Mpps  |   0 %  |
> +---------------------------------------------------------+
>
> Notes on test:
> - System: Intel(R) Xeon(R) Platinum 8380 CPU @ 2.30GHz
> - oncpu: NAPI and application running on same CPU
> - offcpu: NAPI and application running on different CPUs
> - MTU: 1500
> - iperf3 tests are single stream, 60s with IPv6 (for slightly larger
>    headers)
> - kperf version [1]
>
> [1] git://git.kernel.dk/kperf.git
>
> Suggested-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Signed-off-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>
> Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en.h  |  20 +-
>   .../ethernet/mellanox/mlx5/core/en/params.c   |  23 --
>   .../net/ethernet/mellanox/mlx5/core/en/txrx.h |   1 -
>   .../net/ethernet/mellanox/mlx5/core/en_main.c | 287 +++++++--------
>   .../net/ethernet/mellanox/mlx5/core/en_rx.c   | 341 +++---------------
>   5 files changed, 188 insertions(+), 484 deletions(-)

Faster and less code is always a nice thing to see.

Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>