Re: [PATCH v2] fs: hugetlb: simplify remove_inode_hugepages() return type

[Andrew Morton]

On Wed, 4 Feb 2026 22:54:48 +0100 "David Hildenbrand (arm)" <david@xxxxxxxxxx> wrote:

> > Changelog
> > =========
> > 
> > v2 -> v1 [2]
> > 
> > - Use two-tab alignment for parameters wrapped to new lines.
> > 
> > - Remove return type in remove_inode_hugepages()'s comment.
> > 
> > [1] https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@xxxxxxxxxx
> > [2] https://lore.kernel.org/linux-mm/20260202233617.2350734-1-jiaqiyan@xxxxxxxxxx
> > 
> > Suggested-by: Jane Chu <jane.chu@xxxxxxxxxx>
> > Reviewed-by: Jane Chu <jane.chu@xxxxxxxxxx>
> > Reviewed-by: Muchun Song <muchun.song@xxxxxxxxx>
> > Acked-by: David Hildenbrand (arm) <david@xxxxxxxxxx>
> > Signed-off-by: Jiaqi Yan <jiaqiyan@xxxxxxxxxx>
> > ---
> 
> For the future, the changelog always belongs down here, under the ---, like
> 
> Signed-off-by: Jiaqi Yan <jiaqiyan@xxxxxxxxxx>
> ---
> 
> Changelog
> ...
> 
>   fs/hugetlbfs/inode.c | 18 ++++++------------
>   1 file changed, 6 insertions(+), 12 deletions(-)
> 
> I think I always add another "---" above the file list, not sure if that 
> is required.

Interpretations might vary but the "^---$" inventor sayeth that
everything below the "^---$" is not part of the changelog and is to be
removed.


Also, my preference is that the permanent upstreamable changelog not
contain short-term development-time information, as that's
uninteresting to someone who is looking at the commit three years from
now.

Material such as "how this patch differes from the previous version"
and "how I tested it" is interesting and useful, but below the "^---$",
please.


Beware that git interprets the separator more loosely: "^-----------"
will match.  So using a row of "-" characters to underline a heading is
a pitfall.