RE: [v6,net-next,15/15] net: fec: add AF_XDP zero-copy support

From: Wei Fang

Date: Thu Feb 05 2026 - 01:06:26 EST


> > + bdp->cbd_bufaddr = cpu_to_fec32(dma);
> > + bdp->cbd_datlen = cpu_to_fec16(len);
> > +
> > + if (fep->bufdesc_ex) {
> > + struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp;
> > +
> > + if (fep->quirks & FEC_QUIRK_HAS_AVB)
> > + estatus |= FEC_TX_BD_FTYPE(txq->bd.qid);
> > +
> > + ebdp->cbd_bdu = 0;
> > + ebdp->cbd_esc = cpu_to_fec32(estatus);
> > + }
> > +
> > + status |= (BD_ENET_TX_READY | BD_ENET_TX_TC);
> > + bdp->cbd_sc = cpu_to_fec16(status);
> > + dma_wmb();
>
> Is there a missing dma_wmb() before setting BD_ENET_TX_READY?

Yes, my bad, I will fix it.