Re: [PATCH v6 1/2] i2c: designware-platdrv: simplify reset control

[Artem Shimko]

Hi Andi,

Thank you for your review!

On Wed, Feb 4, 2026 at 4:43 AM Andi Shyti <andi.shyti@xxxxxxxxxx> wrote:
> the dev_err_probe() changes are not mentioned in the commit log.
> Can you please split this patch in two, one for the
> devm_reset_control and one for the dev_err_probe?

May I suggest to keep the commit as it is? From my point of view this
dev_err_probe() relates to changes of the reset. Otherwise, I'll have
to return the reset_control_assert() to the first commit, that's
unnecessary when we use the
devm_reset_control_get_optional_exclusive_deasserted().

It'll look like:
1. devm_reset_control_get_optional_exclusive()  +
reset_control_deassert() to
devm_reset_control_get_optional_exclusive_deasserted() keeping at the
same time unnecessary reset_control_assert()
2. removing reset_control_assert()
3. cleanup of exit_probe

My suggestion:
1. change devm_reset_control_get_optional_exclusive()  +
reset_control_deassert() to
devm_reset_control_get_optional_exclusive_deasserted() as well as
remove unneeded reset_control_assert()
2. cleanup of exit_probe

Regards,
Artem