Re: [PATCH v7 1/3] dt-bindings: soc: cix: document the simple-mfd syscon on Sky1 SoC

From: Krzysztof Kozlowski

Date: Thu Feb 05 2026 - 04:18:12 EST


On Wed, Feb 04, 2026 at 10:06:42AM +0800, Gary Yang wrote:
> There are two system control on Cix sky1 Soc. One is located in S0 domain,
> and the other is located in S0 and S5 domain. The system control contains
> resets, usb typeC and more. At this point, only the reset controller child
> is described as usb typeC uses it by phandle.
>
> Signed-off-by: Gary Yang <gary.yang@xxxxxxxxxxx>
> ---
> .../soc/cix/cix,sky1-system-control.yaml | 49 ++++++
> include/dt-bindings/reset/cix,sky1-rst-fch.h | 42 +++++
> include/dt-bindings/reset/cix,sky1-rst.h | 164 ++++++++++++++++++
> 3 files changed, 255 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h
> create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h
>
> diff --git a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> new file mode 100644
> index 000000000000..5fb6b97c3c00
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/cix/cix,sky1-system-control.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cix Sky1 SoC system control register region
> +
> +maintainers:
> + - Gary Yang <gary.yang@xxxxxxxxxxx>
> +
> +description:
> + An wide assortment of registers of the system controller on Sky1 SoC,
> + including resets, usb, wakeup sources and so on.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - cix,sky1-system-control
> + - cix,sky1-s5-system-control
> + - const: syscon
> + - const: simple-mfd

Drop simple-mfd, no children

> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':

Drop, no children

> + const: 1
> +
> + '#size-cells':

Drop

Do you see any recent simple-mfd binding written like this? There are
no. Did you read any of other bindings before sending this? Or at least
my slides or amny other resources from vast documentation from
elinux.org?

Best regards,
Krzysztof