Re: [PATCH 1/2] dt-bindings: input: add GPIO charlieplex keypad

[Dmitry Torokhov]

Hi Hugo,

On Tue, Feb 03, 2026 at 10:49:47AM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> 
> Add DT bindings for GPIO charlieplex keypad.
> 

...

> +  linux,no-autorepeat:
> +    type: boolean
> +    description: Do not enable autorepeat feature.

Let's use standard "autorepeat" property to enable autorepeat when
needed.

> +
> +  gpio-activelow:
> +    type: boolean
> +    description:
> +      Force GPIO polarity to active low.
> +      In the absence of this property GPIOs are treated as active high.

No, the polarity should be encoded in individual GPIOs, not via a
separate property.

Thanks.

-- 
Dmitry