Re: [PATCH v3 4/4] staging: greybus: resolved checkpatch checks for light.c

[Rui Miguel Silva]

Hey Rachit,
Thanks for the patch. And the sending corrections along the path.

On Wed Feb 4, 2026 at 6:31 PM WET, Rachit Dhar wrote:

> Added comment to mutex declarations, to resolve checkpatch.pl checks.
>
> Signed-off-by: Rachit Dhar <rchtdhr@xxxxxxxxx>
> ---
>  drivers/staging/greybus/light.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index e509fdc715db..1f2faa6d545d 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -37,7 +37,7 @@ struct gb_channel {
>  	bool				releasing;
>  	bool				strobe_state;
>  	bool				active;
> -	struct mutex			lock;
> +	struct mutex			lock; /* protects gb_channel->active */
>  };
>  
>  struct gb_light {
> @@ -59,7 +59,7 @@ struct gb_lights {
>  	struct gb_connection	*connection;
>  	u8			lights_count;
>  	struct gb_light		*lights;
> -	struct mutex		lights_lock;
> +	struct mutex		lights_lock; /* protects gb_lights->lights */
>  };
>  


This LGTM.

Acked-by: Rui Miguel Silva <rui.silva@xxxxxxxxxx>

Cheers,
    Rui

>  static void gb_lights_channel_free(struct gb_channel *channel);
> -- 
> 2.43.0