Re: [PATCH v2 1/3] dt-bindings: usb: introduce fsl,imx-dwc3

From: Xu Yang

Date: Thu Feb 05 2026 - 05:58:14 EST


On Wed, Feb 04, 2026 at 07:46:11AM -0600, Rob Herring wrote:
> On Wed, Feb 4, 2026 at 5:05 AM Xu Yang <xu.yang_2@xxxxxxx> wrote:
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - fsl,imx8mp-dwc3
>
> You can't reuse the same compatible for a new binding.

OK. Will use a different name.

>
> > + - fsl,imx94-dwc3
> > + - fsl,imx95-dwc3
> > + - const: fsl,imx-dwc3
>
> Drop. If you want a fallback, use the 1st SoC's compatible.

OK.

>
> > +
> > + reg:
> > + items:
> > + - description: DWC3 core registers
> > + - description: HSIO Block Control registers
> > + - description: Wrapper registers of dwc3 core
> > +

[...]

> > + power-domains = <&scmi_devpd 13>; //IMX94_PD_HSIO_TOP
> > + phys = <&usb3_phy>, <&usb3_phy>;
> > + phy-names = "usb2-phy", "usb3-phy";
> > + snps,gfladj-refclk-lpm-sel-quirk;
> > + snps,parkmode-disable-ss-quirk;
> > + status = "disabled";
>
> Examples should be enabled.

OK.

Thanks,
Xu Yang