Re: [PATCH 1/5] export file_close_fd and task_work_add

From: Alice Ryhl

Date: Thu Feb 05 2026 - 07:07:40 EST


On Thu, Feb 05, 2026 at 12:52:37PM +0100, Jan Kara wrote:
>
> Agreed. And just to demonstrate the point binder's use would become the
> first of such bugs because it is prone to the module being removed while
> the task work is in flight and thus do_close_fd() code can be freed by the
> time it gets executed.

Good point ...

> Generally, making some code modular usually requires more effort than just
> flipping the Kconfig to tristate. You usually need to make sure all objects
> and queued work is flushed before the module can be removed. Not sure how
> much of this is taken care of by Rust though...
>
> Honza
> --
> Jan Kara <jack@xxxxxxxx>
> SUSE Labs, CR