Re: [PATCH v4 2/5] netfilter: ftp: annotate nf_nat_ftp_hook with __rcu

[sun jian]

On Thu, Feb 5, 2026 at 6:00 PM Florian Westphal <fw@xxxxxxxxx> wrote:
>
> Sun Jian <sun.jian.kdev@xxxxxxxxx> wrote:
>
> Patch 1 re-indents, the rest doesn't.
>
> > diff --git a/net/netfilter/nf_conntrack_ftp.c b/net/netfilter/nf_conntrack_ftp.c
> CHECK: Alignment should match open parenthesis
> #135: FILE: net/netfilter/nf_conntrack_ftp.c:47:
> +unsigned int (__rcu *nf_nat_ftp_hook)(struct sk_buff *skb,
>                                 enum ip_conntrack_info ctinfo,
>
> Please re-indent in .c and check that checkpatch.pl doesn't complain.
>
> Also, no need to send this in multiple patches, its one logical
> annotation change.

Ack. I'll squash these into a single patch and fix the alignment issues.
v5 is coming soon.

Regards,
sun jian