Re: [PATCH net-next v3] net: dsa: eliminate local type for tc policers

[Paolo Abeni]

On 2/3/26 6:22 PM, David Yang wrote:
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 596ab9791e4d..a2b1b752958a 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -275,7 +275,7 @@ struct flow_action_entry {
>  			u32			trunc_size;
>  			bool			truncate;
>  		} sample;
> -		struct {				/* FLOW_ACTION_POLICE */
> +		struct flow_action_police {		/* FLOW_ACTION_POLICE */
>  			u32			burst;
>  			u64			rate_bytes_ps;
>  			u64			peakrate_bytes_ps;

I find a bit unusual put the new type definition inside a wider struct.
I think it would be better move the struct flow_action_police standalone.

/P