Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support

[Guenter Roeck]

On Thu, Feb 05, 2026 at 02:46:29PM +0100, Krzysztof Kozlowski wrote:
> On Thu, Feb 05, 2026 at 06:01:37PM +0800, Carl Lee wrote:
> > Add device type support for MPQ8786
> > 
> > Signed-off-by: Carl Lee <carl.lee@xxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > index 90970a0433e9..aec7397a29f9 100644
> > --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > @@ -19,6 +19,7 @@ properties:
> >        - mps,mpm3695-25
> >        - mps,mpm82504
> >        - mps,mpq8785
> > +      - mps,mpq8786
> 
> Your driver code says they are the same, so compatible. Express it with
> fallback or provide real rationale in commit msg.
> 

Agreed. The mpq8785 datasheet is public, but the mpq8786 datasheet isn't.
That makes it all but impossible to determine if there are indeed no
notable differences between the chips.

Guenter