Re: [PATCH v5 next 7/7] iio: sca3000: manage device registration with devm helper
From: Harshit Mogalapalli
Date: Thu Feb 05 2026 - 12:01:12 EST
Hi Andy,
On 05/02/26 22:26, Andy Shevchenko wrote:
On Thu, Feb 5, 2026 at 6:51 PM Harshit Mogalapalli
<harshit.m.mogalapalli@xxxxxxxxxx> wrote:
On 05/02/26 21:59, Andy Shevchenko wrote:
On Thu, Feb 05, 2026 at 05:12:13AM -0800, Harshit Mogalapalli wrote:
...
- struct iio_dev *indio_dev = spi_get_drvdata(spi);
Do you still need spi_set_drvdata() or analogue in the ->probe()?
That's a great catch, I don't see spi_get_drvdata() anymore after this
series, so yes I think we should get rid of this.
Should I fold that into this patch in v6, as spi_get_drvdata() is also
removed in this patch ?
Ideally it should be done in this patch, but let's wait for Jonathan.
He usually may tweak these small things when applying.
Also, while checking the patch now, I see I copied a wrong tag(RB with missing r in baylibre from [1])
So that's one more thing to fix. Let me know if v6 would be a preferred approach, I can do it.
Thanks,
Harshit
[1] https://lore.kernel.org/all/a5fa2f97-9ba3-4085-bfaf-a255d24a81f0@xxxxxxxxxxxx/