Re: [PATCH v7 4/8] iio: adc: ad4030: Use BIT macro to improve code readability
From: Andy Shevchenko
Date: Thu Feb 05 2026 - 12:03:12 EST
On Thu, Feb 05, 2026 at 01:48:19PM -0300, Marcelo Schmitt wrote:
> Use BIT macro to make the list of average modes more readable.
Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
...
> + BIT(0),
Maybe a comment here (yes, I read the top comment,
this is just for the sake of preventing regrouping
in the future).
BIT(0), /* No sampling average */
but again, no need to resend for this tiny thing.
> + BIT(1), BIT(2), BIT(3), BIT(4),
> + BIT(5), BIT(6), BIT(7), BIT(8),
> + BIT(9), BIT(10), BIT(11), BIT(12),
> + BIT(13), BIT(14), BIT(15), BIT(16),
--
With Best Regards,
Andy Shevchenko