Re: [PATCH v7 5/8] iio: adc: ad4030: Add SPI offload support

[Andy Shevchenko]

On Thu, Feb 05, 2026 at 07:08:48PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 05, 2026 at 01:48:40PM -0300, Marcelo Schmitt wrote:

...

> > +	cnv_wf.period_length_ns = DIV_ROUND_CLOSEST(NSEC_PER_SEC, cnv_rate_hz);

> > +	offload_period_ns = DIV_ROUND_CLOSEST(NSEC_PER_SEC, freq_hz);

^^^ for the context to the below remark.

...

> > +	config->periodic.frequency_hz = DIV_ROUND_UP_ULL(NSEC_PER_SEC,
> > +							 offload_period_ns);
> 
> The point of having _ULL version here is...?

And for the consistency with the above this should be HZ_PER_GHZ.

-- 
With Best Regards,
Andy Shevchenko