Re: [PATCH net-next v3 0/4] amd-xgbe: add ARP offload and RSS self-tests

From: Jakub Kicinski

Date: Thu Feb 05 2026 - 22:09:14 EST


On Wed, 4 Feb 2026 20:28:29 +0530 Raju Rangoju wrote:
> amd-xgbe: do not select NET_SELFTESTS when INET is disabled

I'll apply this one

> amd-xgbe: add hardware ARP offload support
> amd-xgbe: add ARP offload ethtool self-test

These two I don't get. The feature is enabled during the test but it
can't be enabled by a normal user. So what's the point of testing it?

> amd-xgbe: add RSS ethtool self-test

xgbe seems to implement Toeplitz hash, much better to run
tools/testing/selftests/drivers/net/hw/toeplitz.py
than just checking if the hash value != 0..