Re: [PATCH 05/10] ASoC: qcom: q6dsp: add support for LPASS LPI MI2S dais

[Krzysztof Kozlowski]

On Thu, Feb 05, 2026 at 12:14:06PM -0500, Srinivas Kandagatla wrote:
> Add new dai ids and dai driver entries ior LPASS LPI MI2S lines
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxxxxxxxx>
> ---
>  .../sound/qcom,q6dsp-lpass-ports.h            | 12 ++++-
>  sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c      | 47 +++++++++++++++++++
>  2 files changed, 58 insertions(+), 1 deletion(-)
> 

It's impossible to reply via korg - wrong address of Conor...

> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> index 609bc278f726..0febc641f351 100644
> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> @@ -140,7 +140,17 @@
>  #define DISPLAY_PORT_RX_6	134
>  #define DISPLAY_PORT_RX_7	135
>  #define USB_RX			136
> -#define LPASS_MAX_PORT		(USB_RX + 1)
> +#define	LPI_MI2S_RX_0		137

Odd indentation appeared.

> +#define	LPI_MI2S_TX_0		138
> +#define	LPI_MI2S_RX_1		139
> +#define	LPI_MI2S_TX_1		140
> +#define	LPI_MI2S_RX_2		141
> +#define	LPI_MI2S_TX_2		142
> +#define	LPI_MI2S_RX_3		143
> +#define	LPI_MI2S_TX_3		144
> +#define	LPI_MI2S_RX_4		145
> +#define	LPI_MI2S_TX_4		146
> +#define	LPASS_MAX_PORT		(LPI_MI2S_TX_4 + 1)

Confusing change or actual proof that my previous comments for similar
patch are valid:
1. not a binding
or
2. you cannot change this, because you break ABI.
Choose only one from these options.

Drop.

Best regards,
Krzysztof