Re: [PATCH] usb: typec: ucsi: Add Thunderbolt alternate mode support

[Heikki Krogerus]

Hi Andrei,

On Mon, Jan 26, 2026 at 09:06:16AM +0000, Andrei Kuchynski wrote:
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * UCSI Thunderbolt Alternate Mode Support
> + *
> + * Copyright 2025 Google LLC

2026

> + */
> +
> +#include <linux/usb/typec_tbt.h>
> +#include <linux/usb/pd_vdo.h>

We now need to include everything instead of relying other
headers to do that for us (although, I don't think this rule is
documented anywhere yet). Include at least these:

linux/err.h
linux/dev_printk.h
linux/device/devres.h
linux/gfp_types.h
linux/types.h
linux/usb/typec_altmode.h
linux/workqueue.h

Otherwise this looks good to me.

thanks,

-- 
heikki