Re: [PATCH] arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT

From: Roger Shimizu

Date: Fri Feb 06 2026 - 04:56:42 EST


On Fri, Feb 6, 2026 at 1:41 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 04/02/2026 10:20, Konrad Dybcio wrote:
> > On 1/31/26 11:31 AM, Roger Shimizu wrote:
> >> ---
> >
> > [...]
> >
> >> +/ {
> >> + model = "Thundercomm AI Mini PC G1 IoT";
> >> + compatible = "qcom,sc7280", "qcom,qcm6490";
> >
> > You need to add a board-specific compatible here, see:
> >
> > Documentation/devicetree/bindings/arm/qcom.yaml
>
> The true problem is that this would probably fail validation, so I
> suspect this was never tested/checked.

Thanks for the review!
I did test this device-tree with the board.
If you mean some other test, please let me know in detail.

-Roger