[bug report] ext4: refactor zeroout path and handle all cases
From: Dan Carpenter
Date: Fri Feb 06 2026 - 08:47:07 EST
[ Smatch checking is paused while we raise funding. #SadFace
https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]
Hello Ojaswin Mujoo,
Commit a985e07c2645 ("ext4: refactor zeroout path and handle all
cases") from Jan 23, 2026 (linux-next), leads to the following Smatch
static checker warning:
fs/ext4/extents.c:3369 ext4_split_extent_zeroout()
warn: duplicate zero check 'err' (previous on line 3363)
fs/ext4/extents.c
3361
3362 err = ext4_ext_get_access(handle, inode, path + depth);
3363 if (err)
3364 return err;
3365
3366 ext4_ext_mark_initialized(ex);
3367
3368 ext4_ext_dirty(handle, inode, path + depth);
Presumably "err = ext4_ext_dirty()".
--> 3369 if (err)
3370 return err;
3371
3372 return 0;
3373 }
regards,
dan carpenter