Re: [PATCH v6 1/4] tracing: Reset last_boot_info if ring buffer is reset
From: Google
Date: Fri Feb 06 2026 - 08:55:33 EST
On Wed, 4 Feb 2026 20:40:49 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Sun, 1 Feb 2026 12:29:07 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
>
> > @@ -8036,6 +8042,7 @@ tracing_snapshot_write(struct file *filp, const char __user *ubuf, size_t cnt,
> > tracing_reset_online_cpus(&tr->max_buffer);
> > else
> > tracing_reset_cpu(&tr->max_buffer, iter->cpu_file);
> > + update_last_data_if_empty(tr);
>
> Is this needed? Memory mapped buffers (which the persistent ring buffer
> is) do not have snapshot buffers.
Yeah, I did this just for consistency. But it is better to just leave
the comment here.
Thank you,
>
> -- Steve
>
>
> > }
> > break;
> > }
>
--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>