Re: [PATCH 2/6] iio: adc: ad4080: add support for AD4082
From: Andy Shevchenko
Date: Fri Feb 06 2026 - 08:59:42 EST
On Fri, Feb 06, 2026 at 03:56:13PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 06, 2026 at 03:08:21PM +0200, Antoniu Miclaus wrote:
> > Add support for AD4082 20-bit SAR ADC. The AD4082 has the same
> > resolution as AD4080 (20-bit) but differs in LVDS CNV clock count
> > maximum (8 vs 7).
>
> > Changes:
> > - Add AD4082_CHIP_ID definition (0x0052)
> > - Create ad4082_channel with 20-bit resolution and 32-bit storage
> > - Add ad4082_chip_info with lvds_cnv_clk_cnt_max = 8
> > - Register AD4082 in device ID and OF match tables
>
> TBH, I think this section is too much for the commit message...
>
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> > ---
>
> ...and just as good to be placed here.
>
> Otherwise, LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Same comments for the patches 4 & 6. With that being addressed,
feel free to add my Rb there as well.
--
With Best Regards,
Andy Shevchenko