Re: [PATCH] dlm: use hlist_for_each_entry_srcu for SRCU protected lists

From: Alexander Aring

Date: Fri Feb 06 2026 - 09:46:34 EST


Hi,

On Fri, Feb 6, 2026 at 12:19 AM lirongqing <lirongqing@xxxxxxxxx> wrote:
>
> From: Li RongQing <lirongqing@xxxxxxxxx>
>
> The connection and node hash tables in DLM are protected by SRCU, but
> the code currently uses hlist_for_each_entry_rcu() for traversal.
> While this works functionally, it is semantically incorrect and triggers
> warnings when RCU lockdep debugging is enabled, as it expects regular
> RCU read-side critical sections.
>

I noticed this as well and came to the same conclusion that it doesn't
matter, but I do agree we should change that because the API can be
changed even in the non debug case.

So thanks for doing this...

Acked-by: Alexander Aring <aahringo@xxxxxxxxxx>

- Alex