Re: [PATCH] revocable: hide the implementation details from users
From: Greg Kroah-Hartman
Date: Fri Feb 06 2026 - 10:08:57 EST
On Fri, Feb 06, 2026 at 11:32:06AM +0100, Bartosz Golaszewski wrote:
> -struct revocable_provider __rcu *revocable_provider_alloc(void *res)
> +revocable_provider_t revocable_provider_alloc(void *res)
While I understand why you did this, and it does save us the "__rcu"
usage which is essencial, it still makes me feel dirty seeing it :)
Also, as the __rcu pointer is now "hidden", what is that going to mean
for sparse usage? Will this accidentally trigger problems if we do
anything with the pointer incorrectly?
thanks,
greg k-h