Re: [PATCH v1 1/2] perf tests: build-test coverage for NO_JEVENTS=1
From: Leo Yan
Date: Fri Feb 06 2026 - 11:09:44 EST
On Fri, Feb 06, 2026 at 11:59:25AM -0300, Arnaldo Carvalho de Melo wrote:
> On Fri, Feb 06, 2026 at 08:53:49AM +0000, Leo Yan wrote:
> > On Thu, Feb 05, 2026 at 10:36:02AM -0800, Ian Rogers wrote:
> > > Leo reported the NO_JEVENTS=1 build being broken and this highlighted
> > > it being missing from the build-test, add it.
> >
> > To be clear, I did not say the build is broken.
> >
> > The issue I reported is that `perf stat` is broken, both with
> > NO_JEVENTS=1 enabled and without that configuration.
> >
> > With updating the commit log, this patch LGTM:
>
> I did it and will apply the Reviewed-by to patch 2/2 too, ok?
Yes, this is fine for me.
Just remind, in patch 02, based on test, we only need to apply the
change in metricgroup__parse_groups() for removing the "!table" check.
The change for metricgroup__has_metric_or_groups() is not quite right,
as we should keep the searching metrics with
pmu_metrics_table__default().
Thanks,
Leo