Re: [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay

[Krzysztof Kozlowski]

On 21/01/2026 19:31, Nihal Kumar Gupta wrote:
> Monaco EVK board does not include a camera sensor in its default hardware
> configuration. Introducing a device tree overlay to support optional
> integration of the IMX577 sensor via CSIPHY1.
> 
> Camera reset is handled through an I2C expander, and power is enabled
> via TLMM GPIO74.
> 
> An example media-ctl pipeline for the imx577 is:
> 
> media-ctl --reset
> media-ctl -V '"imx577 3-001a":0[fmt:SRGGB10/4056x3040 field:none]'
> media-ctl -V '"msm_csiphy1":0[fmt:SRGGB10/4056x3040]'
> media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
> media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
> media-ctl -l '"msm_csiphy1":1->"msm_csid0":0[1]'
> media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
> yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video1
> 
> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@xxxxxxxxxxx>
> Co-developed-by: Ravi Shankar <quic_rshankar@xxxxxxxxxxx>
> Signed-off-by: Ravi Shankar <quic_rshankar@xxxxxxxxxxx>
> Co-developed-by: Vishal Verma <quic_vishverm@xxxxxxxxxxx>
> Signed-off-by: Vishal Verma <quic_vishverm@xxxxxxxxxxx>
> Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |  4 ++
>  .../dts/qcom/monaco-evk-camera-imx577.dtso    | 66 +++++++++++++++++++
>  2 files changed, 70 insertions(+)


So many people developed it, three people reviewed it, patch is at v9 and...

still was not build-tested by the author. At this point this is big
surprise.

NAK

Best regards,
Krzysztof