Re: [PATCH v3 1/2] dt-bindings: hwmon: add support for MCP998X

[Krzysztof Kozlowski]

On 06/02/2026 15:17, Victor.Duicu@xxxxxxxxxxxxx wrote:
>>> +
>>> +  interrupts:
>>> +    items:
>>> +      - description: Signal coming from ALERT/THERM pin.
>>> +      - description: Signal coming from THERM/ADDR pin.
>>> +      - description: Signal coming from SYS_SHDN pin.
>>> +
>>> +  interrupt-names:
>>> +    items:
>>> +      - const: alert-therm
>>> +      - const: therm-addr
>>> +      - const: sys-shutdown
>>
>> The top-level definition of interrupt-names specifies exactly 3
>> items.
>> How does this interact with variants that only have 2 interrupts?
>>
> 
> The chips with "D" in the family have the sys-shutdown and alert-therm
> interrupt pins. The rest have alert-therm and therm-addr interrupt
> pins. The conditional assigns the interrupt names depending on the
> chip.


No, the top level says you have three interrupts. Do not create bindings
which contradict themselves.

More important I am 100% sure this fails tests if you wrote proper, so a
complete example. It passes only because you made a limited example,
without properties.

No, drop review, fix and request re-review.

Best regards,
Krzysztof