Re: [PATCH v3 10/26] coco/tdx-host: Implement FW_UPLOAD sysfs ABI for TDX Module updates
From: Xing, Cedric
Date: Fri Feb 06 2026 - 12:16:12 EST
On 1/23/2026 8:55 AM, Chao Gao wrote:
[...]
+I can't speak for others but the name "seamldr_upload" here doesn't look intuitive to me. Given this FW node will show up in /sys/class/firmware/, I'd name it "tdx_module" to indicate to the user clearly that this is for updating the TDX module.
+static void seamldr_init(struct device *dev)
+{
+ const struct tdx_sys_info *tdx_sysinfo = tdx_get_sysinfo();
+ int ret;
+
+ if (WARN_ON_ONCE(!tdx_sysinfo))
+ return;
+
+ if (!IS_ENABLED(CONFIG_INTEL_TDX_MODULE_UPDATE))
+ return;
+
+ if (!tdx_supports_runtime_update(tdx_sysinfo))
+ pr_info("Current TDX Module cannot be updated. Consider BIOS updates\n");
+
+ tdx_fwl = firmware_upload_register(THIS_MODULE, dev, "seamldr_upload",
-Cedric