Re: [PATCH v5 6/7] sample: rust: pci: use `register!` macro

[Danilo Krummrich]

On Thu Jan 29, 2026 at 2:32 PM CET, Alexandre Courbot wrote:
> Convert the direct IO accesses to properly defined registers.
>
> Tested-by: Zhi Wang <zhiw@xxxxxxxxxx>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>

I think you forgot the address my comment from [1].

Changing the config space is nice, but I think it would be even nicer to replace
the raw register writes and reads of the pci::Bar.

[1] https://lore.kernel.org/all/DG2DEH4ELYHK.2KUOIDQAILZHT@xxxxxxxxxx/