Re: [PATCH v3 20/30] gpu: nova-core: Hopper/Blackwell: add FSP message structures

From: Timur Tabi

Date: Fri Feb 06 2026 - 14:41:48 EST


On Thu, 2026-02-05 at 20:21 -0800, John Hubbard wrote:
> +pub(crate) struct FmcSignatures {
> +    hash384: [u32; 12],    // SHA-384 hash (48 bytes)
> +    public_key: [u32; 96], // RSA public key (384 bytes)
> +    signature: [u32; 96],  // RSA signature (384 bytes)
> +}

You're not treating this fields as arrays of 32-bit integers (and semantically, I don't think they
are defined that way anyway), so why define them as such? If you change them to [u8; then you might
not need .as_bytes_mut() in the next patch. This also avoids any endian weirdness that can occur.
Plus, you'll be able to do this:

hash384: [u8; FSP_HASH_SIZE]