Re: [PATCH] i2c: tegra: Don't mark devices with pins as IRQ safe
From: Andi Shyti
Date: Fri Feb 06 2026 - 19:25:17 EST
Hi Mikko,
> - if (!IS_VI(i2c_dev) && !has_acpi_companion(i2c_dev->dev))
> + if (!IS_VI(i2c_dev) && !has_acpi_companion(i2c_dev->dev) && !i2c_dev->dev->pins)
I'm sorry, I had to remove your patch. The ->pins member is
conditional to CONFIG_PINCTRL, without it we get this compile
error:
drivers/i2c/busses/i2c-tegra.c: In function 'tegra_i2c_probe':
>> drivers/i2c/busses/i2c-tegra.c:1842:82: error: 'struct device' has no member named 'pins'
1842 | if (!IS_VI(i2c_dev) && !has_acpi_companion(i2c_dev->dev) && !i2c_dev->dev->pins)
| ^~
Please fix it and resubmit a v2.
Thanks,
Andi