Re: [PATCH] arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT

[Roger Shimizu]

On Fri, Feb 6, 2026 at 2:20 AM Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
> On 2/6/26 10:55 AM, Roger Shimizu wrote:
> > On Fri, Feb 6, 2026 at 1:41 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >>
> >> On 04/02/2026 10:20, Konrad Dybcio wrote:
> >>> On 1/31/26 11:31 AM, Roger Shimizu wrote:
> >>>> ---
> >>>
> >>> [...]
> >>>
> >>>> +/ {
> >>>> +    model = "Thundercomm AI Mini PC G1 IoT";
> >>>> +    compatible = "qcom,sc7280", "qcom,qcm6490";
> >>>
> >>> You need to add a board-specific compatible here, see:
> >>>
> >>> Documentation/devicetree/bindings/arm/qcom.yaml
> >>
> >> The true problem is that this would probably fail validation, so I
> >> suspect this was never tested/checked.
> >
> > Thanks for the review!
> > I did test this device-tree with the board.
> > If you mean some other test, please let me know in detail.
>
> make ... CHECK_DTBS=1 qcom/qcs6490-thundercomm-minipc-g1iot.dtb

Thanks for the guide!
I tested above command, it was passed for my v1.
Sure, it also passes after I add the board-specific compatible. (not send yet)

> make ... dt_binding_check

Sorry, I never can run this check command. It reports many python syntax error.
I guess the script has issue, or it needs patch to run on my Debian system.
I'll report the issue to upstream separately.

-Roger