Re: [PATCH v4 6/6] nvmem: rockchip-otp: Add support for RK3528

[Willy Tarreau]

Hi Heiko,

On Thu, Feb 05, 2026 at 10:19:01PM +0100, Heiko Stuebner wrote:
> From: Jonas Karlman <jonas@xxxxxxxxx>
> 
> Add support for the OTP controller in RK3528. The OTPC is similar to the
> OTPC in RK3562 and RK3568, exept for a missing phy clock and reset.
> 
> Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx>
> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>

This time I'm making sure to respond to the right patch :-)

I applied your series on top of latest master and booted it on my
E20C (rk3528-based). It provides me with entries in which I can
read values, like when I applied Jonas' patch on 6.17, so I guess
that it's OK:

  # for i in /sys/devices/platform/soc/*/rockchip-otp0/cells/*; do echo ${i##*/}:;hexdump $i;done
  cpu-code@2,0:
  0000000 2835                                   
  0000002
  cpu-leakage@1a,0:
  0000000 000e                                   
  0000001
  cpu-version@8,3:
  0000000 0001                                   
  0000001
  gpu-leakage@1c,0:
  0000000 0003                                   
  0000001
  id@a,0:
  0000000 4e54 5532 3433 0000 0000 0000 0800 112d
  0000010
  logic-leakage@1b,0:
  0000000 0017                                   
  0000001
  tsadc-trim@44,0:
  0000000 0200                                   
  0000002

So feel free to add this if you want:

Tested-by: Willy Tarreau <w@xxxxxx>

Willy