Re: [PATCH v4] staging: rtl8723bs: fix potential race in expire_timeout_chk
From: Greg KH
Date: Sat Feb 07 2026 - 07:06:46 EST
On Sun, Feb 01, 2026 at 02:11:53AM +0900, Minu Jin wrote:
> The expire_timeout_chk function currently do lock and unlock inside the
> loop before calling rtw_free_stainfo().
>
> This can be risky as the list might be changed
> when the lock is briefly released.
>
> To fix this, move expired sta_info entries into a local free_list while
> holding the lock, and then perform the actual freeing after the lock is
> released.
>
> Signed-off-by: Minu Jin <s9430939@xxxxxxxxx>
> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> Changes in v4:
> - Add Reviewed-by tag from Dan Carpenter
You never have to do this. Our tools pick that up, and this just moves
you further down the review queue as it's a new submission :(
thanks,
greg k-h