RE: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1 support

[Thomas Gleixner]

On Sat, Feb 07 2026 at 03:50, Ryan Chen wrote:
>> -----Original Message-----
>> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> Sent: Friday, February 6, 2026 7:34 PM
>> To: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>;
>> Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
>> <conor+dt@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; Andrew Jeffery
>> <andrew@xxxxxxxxxxxxxxxxxxxx>; Paul Walmsley <pjw@xxxxxxxxxx>; Palmer
>> Dabbelt <palmer@xxxxxxxxxxx>; Albert Ou <aou@xxxxxxxxxxxxxxxxx>;
>> Alexandre Ghiti <alex@xxxxxxxx>
>> Cc: linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx;
>> linux-riscv@xxxxxxxxxxxxxxxxxxx; Ryan Chen <ryan_chen@xxxxxxxxxxxxxx>
>> Subject: Re: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1
>> support

Please fix your email client to not copy all mail headers. If you can't
fix it, remove them manually and replace it with the usual:

On Fri, Feb 06 2026 at ...., Thomas Gleixner wrote:
>> > +	guard(raw_spinlock_irqsave)(&intc0->intc_lock);
>> 
>> s/_irqsave// Interrupts are disabled when this is invoked.
> Sorry, do you mean when this function been call.
> Ther have desc->lock to do the raw_spin_lock_irqsave.

The core always holds irq_desc::lock with interrupts disabled when it
invokes those irqchip callbacks. So trying to disable interrupts in them
again is a pointless exercise.