Re: [PATCH v6 2/8] iio: core: add fixed point parsing with 64-bit parts

[Jonathan Cameron]

On Wed, 4 Feb 2026 12:34:52 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Wed, Feb 04, 2026 at 10:28:05AM +0000, Rodrigo Alencar wrote:
> > On 26/02/04 11:57AM, Andy Shevchenko wrote:  
> > > On Wed, Feb 04, 2026 at 09:42:55AM +0000, Rodrigo Alencar wrote:  
> > > > On 26/02/04 03:45AM, Andy Shevchenko wrote:  
> > > > > On Fri, Jan 30, 2026 at 10:06:43AM +0000, Rodrigo Alencar via B4 Relay wrote:  
> 
> ...
> 
> > > > > There is a development in the parse_integer in the lib/. I reviewed that series
> > > > > and hopefully it will go in. With that done, we better reuse the lib/ function.
> > > > > 
> > > > > https://lore.kernel.org/linux-hardening/20260202115451.290173-1-dmantipov@xxxxxxxxx/  
> > > > 
> > > > In this patch, I see that it updates the overflow check, but I am not
> > > > seeing that function being exposed to other kernel modules.  
> > > 
> > > Can the IIO be compiled as a module? If so, then we would need to export that
> > > function. (Note, we may export only for the exact module(s) in question, so
> > > nobody else will be able to use it. See EXPORT_SYMBOL_FOR_MODULES() macro.)  
> > 
> > Yes, one can have an industrialio.ko.
> > Then, would it be fine to use:
> > 
> > EXPORT_SYMBOL_FOR_MODULES(_parse_integer_limit, "industrialio");
> > 
> > in lib/kstrtox.c; and:
> > 
> > #include "../../lib/kstrtox.h"
> > 
> > in drivers/iio/industrialio-core.c
> > 
> > that does not look pretty.  
> 
> Yeah, but I think it's fine as long as we have an associated FIXME.
> In any case Jonathan is the one who makes a decision here.

You've lost me. Why do we need to restrict this function to use
by specific modules?  We normally only bother with that dance when
there is a big footgun or something deep in core kernel code where
we want to be very careful who uses it.

To me it doesn't seem appropriate here.

Jonathan



>