Re: [PATCH v2 01/11] dt-bindings: regulator: cpcap-regulator: convert to DT schema
From: David Lechner
Date: Sat Feb 07 2026 - 12:20:26 EST
On 2/7/26 3:20 AM, Svyatoslav Ryhel wrote:
> сб, 7 лют. 2026 р. о 01:09 Rob Herring <robh@xxxxxxxxxx> пише:
>>
>> On Fri, Feb 06, 2026 at 07:28:35PM +0200, Svyatoslav Ryhel wrote:
>>> Convert devicetree bindings for the Motorola CPCAP MFD regulator subnode
>>> from TXT to YAML format. Main functionality preserved.
>>>
...
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - motorola,cpcap-regulator
>>> + - motorola,mapphone-cpcap-regulator
>>> + - motorola,xoom-cpcap-regulator
>>> +
>>> + regulators:
>>> + type: object
>>> +
>>> + patternProperties:
>>> + "$[A-Z0-9]+^":
>>
>> I thought it was said on the last version to list the names. Considering
>> you already have them below, better to put them in schema than prose.
>> And pretty much all regulator bindings define the names.
>>
>
> What exactly do you propose? All those names will not fit into a
> single unbreakable line (more than 125 columns in length btw). Patch
> checker will complain about this. Duplicate pattern properties for
> every few names? Please be a bit more specific. Thank you!
Making checkpatch happy is not a hard requirement. If you have to
go over 125 characters for technical reasons, no one is going to
complain.
I already gave an example on the last version. It is just a regex
expression. (And note that you didn't fix the $ and ^ either. ^
means beginning of the line and $ means the end of the line. So
the pattern currently won't match anything.)
patternProperties:
"^(SW1|SW2|SW3|SW4|SW5|...)$":
And I hope it is obvious that you are meant to replace ... with the
rest of the names separated by |.