Re: [PATCH v2 0/4] x86 suspend cleanups

[Brian Gerst]

On Wed, Feb 4, 2026 at 4:47 AM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote:
>
>
> On Tue, 3 Feb 2026, at 18:58, Brian Gerst wrote:
> > This patchset cleans up the do_suspend_lowlevel() function, removing
> > some leftover bits that are no longer necessary since it started
> > using the SMP trampoline to resune the kernel.
> >
> > v2:
> > - Reworked the first patch
> > - Added more cleanups
> >
> > Brian Gerst (4):
> >   x86/acpi/suspend: Remove indirect jump
> >   x86/acpi/suspend: Remove segment reloads on resume
> >   x86/acpi/suspend: Clean up stack usage
> >   x86/acpi/suspend: Remove redundant register saves
> >
>
> This all looks correct to me - the stack changes in patch #3 do result in the stack misalignment to be different than it was before, but it is still 8 byte aligned throughout, which is all we care about in the kernel IIRC?

Yes, the kernel uses 8-byte alignment (-mpreferred-stack-boundary=3)
instead of the default 16 for space savings.