Re: [PATCH v5 3/3] gpio: brcmstb: allow parent_irq to wake

[Linus Walleij]

On Wed, Feb 4, 2026 at 5:43 PM Florian Fainelli
<florian.fainelli@xxxxxxxxxxxx> wrote:

> From: Doug Berger <opendmb@xxxxxxxxx>
>
> The classic parent_wake_irq can only occur after the system has
> been placed into a hardware managed power management state. This
> prevents its use for waking from software managed suspend states
> like s2idle.
>
> By allowing the parent_irq to be enabled for wake enabled GPIO
> during suspend, these GPIO can now be used to wake from these
> states. The 'suspended' boolean is introduced to support wake
> event accounting.
>
> Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
> [florian: port changes after generic gpio chip conversion]
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

This looks correct as far as I can understand.
I wish all GPIO drivers has as elaborate wakeup handling...
I will look at this driver to see how it should be done properly.

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij