Re: [PATCH v3 1/7] dt-bindings: clock: qcom,sm8250-videocc: account for the MX domain

[Krzysztof Kozlowski]

On 05/02/2026 13:48, Dmitry Baryshkov wrote:
>>
>>> +  clock-names:
>>> +    items:
>>> +      - const: iface
>>> +      - const: bi_tcxo
>>> +      - const: bi_tcxo_ao
>>> +
>>> +  power-domains:
>>> +    items:
>>> +      - description:
>>> +          A phandle and PM domain specifier for the MMCX power domain.
>>> +      - description:
>>> +          A phandle and PM domain specifier for the MX power domain.
>>
>> This is an ABI break, so please say in the commit what was not working
>> or why this ABI break is really justified. Currently you just give a
>> hint that it is needed for PLL configuration, but honestly - why would
>> we care to configure PLL if everything was working correct before?
> 
> I must admit, I c&p'ed the commit message from [1] which was ack'ed by
> Rob and accepted into the kernel. What is the difference?

No difference. To me both are insufficiently explained as fixes, but
other maintainer might have different opinion. I don't mind that.

> 
> [1] https://lore.kernel.org/all/20250530-videocc-pll-multi-pd-voting-v5-1-02303b3a582d@xxxxxxxxxxx/
> 


Best regards,
Krzysztof