Re: [PATCH v2 02/12] dt-bindings: leds: document Samsung S2M series PMIC RGB LED device

[Jacek Anaszewski]

Hi Kaustabh,

On 2/6/26 14:56, Kaustabh Chakraborty wrote:
> On 2026-02-06 07:38 -06:00, Rob Herring wrote:
> > On Mon, Jan 26, 2026 at 12:37:09AM +0530, Kaustabh Chakraborty wrote:
> > > Certain Samsung S2M series PMICs have a three-channel LED device with
> > > independent brightness control for each channel, typically used as
> > > status indicators in mobile phones. Document the devicetree schema from
> > > this device.
> > >
> > > Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
> > > ---
> > >   .../bindings/leds/samsung,s2mu005-rgb.yaml         | 34 ++++++++++++++++++++++
> > >   1 file changed, 34 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/leds/samsung,s2mu005-rgb.yaml b/Documentation/devicetree/bindings/leds/samsung,s2mu005-rgb.yaml
> > > new file mode 100644
> > > index 0000000000000..6806b6d869ff7
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/leds/samsung,s2mu005-rgb.yaml
> > > @@ -0,0 +1,34 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/leds/samsung,s2mu005-rgb.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: RGB LED Controller for Samsung S2M series PMICs
> > > +
> > > +maintainers:
> > > +  - Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
> > > +
> > > +description: |
> > > +  The Samsung S2M series PMIC RGB LED is a three-channel LED device with
> > > +  8-bit brightness control for each channel, typically used as status
> > > +  indicators in mobile phones.
> > > +
> > > +  This is a part of device tree bindings for S2M and S5M family of Power
> > > +  Management IC (PMIC).
> > > +
> > > +  See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for
> > > +  additional information and example.
> > > +
> > > +allOf:
> > > +  - $ref: common.yaml#
> >
> > This looks a bit lacking. Don't you need 3 child nodes for each or
> > reference to the multi-color schema?
>
> 	rgb {
> 		compatible = "samsung,s2mu005-rgb";
> 		label = "notification:rgb:indicator";
> 		color = <LED_COLOR_ID_RGB>;
> 		function = LED_FUNCTION_INDICATOR;
> 		linux,default-trigger = "pattern";
> 	};

Having label together with color and function doesn't make sense.
Please read label documentation in [0].

[0] Documentation/devicetree/bindings/leds/common.yaml

--
Best regards,
Jacek Anaszewski