RE: [PATCH v2 2/3] wifi: iwlwifi: fw: replace use of system_unbound_wq with system_dfl_wq

[Korenblit, Miriam Rachel]

> -----Original Message-----
> From: Marco Crivellari <marco.crivellari@xxxxxxxx>
> Sent: Thursday, November 20, 2025 12:09 PM
> To: linux-kernel@xxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx
> Cc: Tejun Heo <tj@xxxxxxxxxx>; Lai Jiangshan <jiangshanlai@xxxxxxxxx>; Frederic
> Weisbecker <frederic@xxxxxxxxxx>; Sebastian Andrzej Siewior
> <bigeasy@xxxxxxxxxxxxx>; Marco Crivellari <marco.crivellari@xxxxxxxx>; Michal
> Hocko <mhocko@xxxxxxxx>; Korenblit, Miriam Rachel
> <miriam.rachel.korenblit@xxxxxxxxx>; Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx>
> Subject: [PATCH v2 2/3] wifi: iwlwifi: fw: replace use of system_unbound_wq
> with system_dfl_wq
> 
> This patch continues the effort to refactor workqueue APIs, which has begun with
> the changes introducing new workqueues and a new alloc_workqueue flag:
> 
>    commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and
> system_dfl_wq")
>    commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
> 
> The point of the refactoring is to eventually alter the default behavior of
> workqueues to become unbound by default so that their workload placement is
> optimized by the scheduler.
> 
> Before that to happen after a careful review and conversion of each individual
> case, workqueue users must be converted to the better named new workqueues
> with no intended behaviour changes:
> 
>    system_wq -> system_percpu_wq
>    system_unbound_wq -> system_dfl_wq
> 
> This way the old obsolete workqueues (system_wq, system_unbound_wq) can be
> removed in the future.
> 
> Suggested-by: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Marco Crivellari <marco.crivellari@xxxxxxxx>
> ---
>  drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
> b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
> index 2ce55859641c..e5f31b82339a 100644
> --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
> +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
> @@ -2933,7 +2933,7 @@ int iwl_fw_dbg_collect_desc(struct iwl_fw_runtime
> *fwrt,
>  	IWL_WARN(fwrt, "Collecting data: trigger %d fired.\n",
>  		 le32_to_cpu(desc->trig_desc.type));
> 
> -	queue_delayed_work(system_unbound_wq, &wk_data->wk,
> +	queue_delayed_work(system_dfl_wq, &wk_data->wk,
>  			   usecs_to_jiffies(delay));
> 
>  	return 0;
> @@ -3237,7 +3237,7 @@ int iwl_fw_dbg_ini_collect(struct iwl_fw_runtime
> *fwrt,
>  	if (sync)
>  		iwl_fw_dbg_collect_sync(fwrt, idx);
>  	else
> -		queue_delayed_work(system_unbound_wq,
> +		queue_delayed_work(system_dfl_wq,
>  				   &fwrt->dump.wks[idx].wk,
>  				   usecs_to_jiffies(delay));
> 
> --
> 2.51.1
Acked-by: Miri Korenblit <miriam.rachel.korenblit@xxxxxxxxx>