Re: [PATCH 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Add vdda-refgen supply for Glymur
From: Krzysztof Kozlowski
Date: Mon Feb 09 2026 - 03:07:52 EST
On Sun, Feb 08, 2026 at 08:49:39PM -0800, Qiang Yu wrote:
> The PCIe QMP PHYs on Glymur require stable reference voltage provided by
> refgen. The refgen itself requires two separate power supplies:
> vdda-refgen0p9 and vdda-refgen1p2.
>
> Since there is no dedicated driver for REFGEN, add vdda-refgen0p9-supply
How does the driver matter for the bindings? If I add dedicated driver
for refgen, then I change the bindings?
There is qcom,sc8280xp-refgen-regulator so why there cannot be
qcom,x1e-refgen-regulator?
> and vdda-refgen1p2-supply properties to the PCIe PHY dt-bindings. Use
> conditional schema to restrict these properties to only Glymur PCIe QMP
> PHYs.
Best regards,
Krzysztof