Re: [PATCH] checkpatch: suggest fsleep() for short msleep() calls
From: Andy Shevchenko
Date: Mon Feb 09 2026 - 03:34:50 EST
On Mon, Feb 09, 2026 at 10:32:44AM +0200, Andy Shevchenko wrote:
> On Sun, Feb 08, 2026 at 10:59:35AM -0500, Neel Bullywon wrote:
> > Update the MSLEEP warning to suggest fsleep() as a duration based
> > sleep API. fsleep() autoselects the best sleep mechanism (udelay,
> > usleep_range, or msleep) based on the requested duration, making
> > it the preferred replacement for short msleep() calls.
> Hmm... My understanding was that the warning itself has a mention of
> usleep_range(). Looking at the patch I think the current wording is
> okay, but it may be expanded to suggest fsleep().
Yeah, I would expand this one to make sure we mention fsleep() and update
the
# prefer usleep_range over udelay
one to also mention fsleep().
--
With Best Regards,
Andy Shevchenko