Re: [PATCH v6 5/5] iio: adc: ad9467: check for backend capabilities
From: Andy Shevchenko
Date: Mon Feb 09 2026 - 03:41:45 EST
On Mon, Feb 09, 2026 at 09:24:09AM +0200, Tomas Melin wrote:
> On 05/02/2026 18:34, Andy Shevchenko wrote:
> > On Thu, Feb 05, 2026 at 12:24:11PM +0000, Tomas Melin wrote:
...
> >> + if (iio_backend_has_caps(st->back, IIO_BACKEND_CAP_BUFFER)) {
> >> + ret = devm_iio_backend_request_buffer(&spi->dev, st->back,
> >> + indio_dev);
> >
> > With
> >
> > struct device *dev = &spi->dev;
> >
> > at the top, this one becomes exactly a 80 character line.
> > And in general it will help cleaning up the rest afterwards.
>
> Given it seems it would still be 81 characters long I would like to
> leave this change as it also creates a bit of noise.
ret = devm_iio_backend_request_buffer(dev, st->back, indio_dev);
We have different arithmetics for sure, I have it 80.
"There are *two* problems in programming: naming, cache invalidation,
and off-by-one error."
> >> + if (ret)
> >> + return ret;
> >> + }
--
With Best Regards,
Andy Shevchenko