Re: [PATCH 1/3] phy: qcom: edp: Correct and clean up eDP/DP combo PHY configuration values

[Yongxing Mou]

On 2/6/2026 6:47 PM, Konrad Dybcio wrote:
> On 2/5/26 10:20 AM, Yongxing Mou wrote:
> > According to the current HPG settings, most eDP/DP combo PHYs can reuse the
> > same configuration values.
>
> Even across the various process nodes?
Emm,Currently, I have only checked the five platforms that already have 
eDP PHY driver support enabled. The results are the same as stated in 
the commit message: in DP mode and in eDP low‑vdiff mode, there are four 
platforms that can reuse the same settings. The HPG I used was the one I 
found on IPCAT. Regarding HRG, please move to next comment.
> > DP mode：
> > 	-sa8775p/sc7280/sc8280xp/x1e80100
> > 	-glymur
> > eDP mode(low vdiff):
> > 	-glymur/sa8775p/sc8280xp/x1e80100
> > 	-sc7280
> > The current driver still keeps multiple versions of these tables and
> > doesn't fully support every combo PHY mode. This patch removes the
> > redundant configs and keeps only the sets we actually use, matching the
> > platforms listed above.
>
> I see that e.g. eDP Low-Vdiff swing setting for RBR is:
Hi, do you mean emphasis settings, i don't see 0x11	0x12 in arr[0][1].
> 		hamoa	kodiak
> arr[0][1]	0x11	0x12
>
> It may be that this changed later during tuning but it's not reflected
> in the docs for kodiak
Emm, if that, where can i get the correct value for tables.. In this 
patch, I’m indeed quite curious why the values before the modification 
differ from those in the HPG. I’m not sure about the reason. The HPG I 
used was taken directly from the current go/ipcat. Could you tell me 
where I can obtain the final table that should be used?
> Konrad