Re: [PATCH v4 06/13] iio: dac: ds4424: use device match data for chip info
From: Andy Shevchenko
Date: Mon Feb 09 2026 - 05:30:04 EST
On Mon, Feb 09, 2026 at 10:22:13AM +0100, Oleksij Rempel wrote:
> On Fri, Feb 06, 2026 at 11:59:50AM +0200, Andy Shevchenko wrote:
> > On Fri, Feb 06, 2026 at 08:57:07AM +0100, Oleksij Rempel wrote:
> > > On Thu, Feb 05, 2026 at 08:43:25PM +0000, Jonathan Cameron wrote:
> > > > On Tue, 3 Feb 2026 16:56:00 +0200
> > > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
...
> > > > > Just do not introduce that change (change of the ->name field) in the original
> > > > > patch, in that case no revert churn would be needed.
> > > > >
> > > > I think this got dealt with in discussion of next version but
> > > > safest route is just have an extra copy of the name in the
> > > > chip_info structure. Then we know it's stable against different
> > > > firmware types etc.
> > >
> > > Something like this?
> >
> > Yes, but make it in the patch that introduces DT support.
>
> Hm, I'm not sure what do you mean. There is no patch which "introduces
> DT support" in this series. Do you mean, this one:
> https://lore.kernel.org/all/20260204140045.390677-7-o.rempel@xxxxxxxxxxxxxx/
Yes, I meant that one.
> Or should it be better a separate patch?
Perhaps just after the above mentioned one. Either works for me.
--
With Best Regards,
Andy Shevchenko