Re: [PATCH v8 1/2] staging: axis-fifo: use u32 for fifo depth flags

[Ovidiu Panait]

Hi Gustavo,

On 2/9/26 1:32 PM, Gustavo Piaz da Silva wrote:
> Update has_rx_fifo and has_tx_fifo types from int to u32 in struct
> axis_fifo.
> 
> The of_property_read_u32() function expects a pointer to u32. Although
> the current code works correctly with int, using u32 aligns the data
> structure with the Device Tree API and prevents potential
> type-mismatch issues.
> 
> Signed-off-by: Gustavo Piaz da Silva <gustavopiazdasilva2102@xxxxxxxxx>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 509d620d6ce7..7bc7bf191250 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -121,8 +121,8 @@ struct axis_fifo {
>  
>  	unsigned int rx_fifo_depth; /* max words in the receive fifo */
>  	unsigned int tx_fifo_depth; /* max words in the transmit fifo */
> -	int has_rx_fifo; /* whether the IP has the rx fifo enabled */
> -	int has_tx_fifo; /* whether the IP has the tx fifo enabled */
> +	u32 has_rx_fifo; /* whether the IP has the rx fifo enabled */
> +	u32 has_tx_fifo; /* whether the IP has the tx fifo enabled */
>  

I think you are working with an older tree, these comments were removed
in commit:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=02b2a366a64f22cc367911d479297772d6269200

Could you please rebase the patches on top of the staging-next branch?
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/?h=staging-next

Thanks,
Ovidiu

>  	wait_queue_head_t read_queue; /* wait queue for asynchronos read */
>  	struct mutex read_lock; /* lock for reading */